Formatting and permissions

.github/workflows/check-dist.yml

@@ -1,42 +1,38 @@
-# In JavaScript actions, `dist/index.js` is a special file. When you reference
+# In JavaScript actions, `dist/` is a special directory. When you reference
-# an action with `uses:`, `dist/index.js` is the code that will be run. For this
+# an action with the `uses:` property, `dist/index.js` is the code that will be
-# project, the `dist/index.js` file is generated from other source files through
+# run. For this project, the `dist/index.js` file is transpiled from other
-# the build process. We need to make sure that the checked-in `dist/index.js`
+# source files. This workflow ensures the `dist/` directory contains the
-# file matches what is expected from the build.
+# expected transpiled code.
 #
-# This workflow will fail if the checked-in `dist/index.js` file does not match
+# If this workflow is run from a feature branch, it will act as an additional CI
-# what is expected from the build.
+# check and fail if the checked-in `dist/` directory does not match what is
-name: Check dist/
+# expected from the build.
+name: Check Transpiled JavaScript
 
 on:
   push:
     branches:
       - main
-    paths-ignore:
-      - '**.md'
   pull_request:
-    paths-ignore:
+
-      - '**.md'
+permissions:
-  workflow_dispatch:
+  contents: read
 
 jobs:
   check-dist:
     name: Check dist/
     runs-on: ubuntu-latest
 
-    permissions:
-      contents: read
-      statuses: write
-
     steps:
       - name: Checkout
         id: checkout
         uses: actions/checkout@v4
 
       - name: Setup Node.js
+        id: setup-node
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version-file: .node-version
           cache: npm
 
       - name: Install Dependencies
@@ -47,7 +43,8 @@ jobs:
         id: build
         run: npm run bundle
 
-      - name: Compare Expected and Actual Directories
+      # This will fail the workflow if the PR wasn't created by Dependabot.
+      - name: Compare Directories
         id: diff
         run: |
           if [ "$(git diff --ignore-space-at-eol --text dist/ | wc -l)" -gt "0" ]; then
@@ -56,10 +53,12 @@ jobs:
             exit 1
           fi
 
-      # If index.js was different than expected, upload the expected version as
+      # If `dist/` was different than expected, and this was not a Dependabot
-      # a workflow artifact.
+      # PR, upload the expected version as a workflow artifact.
-      - uses: actions/upload-artifact@v3
+      - if: ${{ failure() && steps.diff.outcome == 'failure' }}
-        if: ${{ failure() && steps.diff.conclusion == 'failure' }}
+        name: Upload Artifact
+        id: upload
+        uses: actions/upload-artifact@v3
         with:
           name: dist
           path: dist/

.github/workflows/ci.yml

@@ -5,7 +5,9 @@ on:
   push:
     branches:
       - main
-      - 'releases/*'
+
+permissions:
+  contents: read
 
 jobs:
   test-javascript:
@@ -21,7 +23,7 @@ jobs:
         id: setup-node
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version-file: .node-version
           cache: npm
 
       - name: Install Dependencies

.github/workflows/linter.yml

@@ -1,23 +1,19 @@
-name: Lint Code Base
+name: Lint Codebase
 
 on:
   pull_request:
+  push:
     branches:
       - main
-  push:
+
-    branches-ignore:
+permissions:
-      - main
+  contents: read
 
 jobs:
   lint:
-    name: Lint Code Base
+    name: Lint Codebase
     runs-on: ubuntu-latest
 
-    permissions:
-      contents: read
-      packages: read
-      statuses: write
-
     steps:
       - name: Checkout
         id: checkout
@@ -27,14 +23,14 @@ jobs:
         id: setup-node
         uses: actions/setup-node@v4
         with:
-          node-version: 20
+          node-version-file: .node-version
           cache: npm
 
       - name: Install Dependencies
         id: install
         run: npm ci
 
-      - name: Lint Code Base
+      - name: Lint Codebase
         id: super-linter
         uses: super-linter/super-linter/slim@v5
         env:
@@ -42,4 +38,5 @@ jobs:
           FILTER_REGEX_EXCLUDE: dist/**/*
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           JAVASCRIPT_DEFAULT_STYLE: prettier
+          VALIDATE_ALL_CODEBASE: true
           VALIDATE_JSCPD: false

.node-version

@@ -0,0 +1 @@
+20.6.0