actions/setup-python
3
0
Fork 0
mirror of https://github.com/actions/setup-python synced 2025-04-05 14:59:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Add .zip extension to Windows package downloads for Expand-Archive Compatibility (#916)

Browse Source 
* Fix: specify filename during Windows package download

* Changed unit test download urls
This commit is contained in:
Priya Gupta
2024-08-05 22:53:34 +05:30
committed by GitHub
parent 04c1311429
commit 036a523674
5 changed files with 77 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
__tests__/utils.test.ts
View File

@ -12,7 +12,9 @@ import {
getVersionInputFromFile,
getVersionInputFromPlainFile,
getVersionInputFromTomlFile,
getNextPageUrl
getNextPageUrl,
IS_WINDOWS,
getDownloadFileName
} from '../src/utils';
jest.mock('@actions/cache');
@ -159,3 +161,37 @@ describe('getNextPageUrl', () => {
expect(getNextPageUrl(generateResponse(page2Links))).toBeNull();
});
});
describe('getDownloadFileName', () => {
const originalEnv = process.env;
const tempDir = path.join(__dirname, 'runner', 'temp');
beforeEach(() => {
process.env = {...originalEnv};
});
afterEach(() => {
process.env = originalEnv;
});
it('should return the correct path on Windows', () => {
if (IS_WINDOWS) {
process.env['RUNNER_TEMP'] = tempDir;
const downloadUrl =
'https://github.com/actions/sometool/releases/tag/1.2.3-20200402.6/sometool-1.2.3-win32-x64.zip';
const expectedPath = path.join(
process.env.RUNNER_TEMP,
path.basename(downloadUrl)
);
expect(getDownloadFileName(downloadUrl)).toBe(expectedPath);
}
});
it('should return undefined on non-Windows', () => {
if (!IS_WINDOWS) {
const downloadUrl =
'https://github.com/actions/sometool/releases/tag/1.2.3-20200402.6/sometool-1.2.3-linux-x64.tar.gz';
expect(getDownloadFileName(downloadUrl)).toBeUndefined();
}
});
});