From 370c75b16c02fc647c89da2a6cc835b353259a57 Mon Sep 17 00:00:00 2001
From: Val Lorentz <progval+opdb@progval.net>
Date: Sun, 21 May 2023 17:49:30 +0200
Subject: [PATCH] Lint tests

---
 glowtables/tests/__init__.py   |  0
 glowtables/tests/conftest.py   | 12 ++++++++++--
 glowtables/tests/table_test.py |  8 +++++---
 pyproject.toml                 |  3 +++
 4 files changed, 18 insertions(+), 5 deletions(-)
 create mode 100644 glowtables/tests/__init__.py

diff --git a/glowtables/tests/__init__.py b/glowtables/tests/__init__.py
new file mode 100644
index 0000000..e69de29
diff --git a/glowtables/tests/conftest.py b/glowtables/tests/conftest.py
index 319f9c3..673f8b6 100644
--- a/glowtables/tests/conftest.py
+++ b/glowtables/tests/conftest.py
@@ -12,6 +12,10 @@
 # You should have received a copy of the GNU Affero General Public License along with
 # this program.  If not, see <http://www.gnu.org/licenses/>.
 
+"""pytest fixtures"""
+
+# pylint: disable=redefined-outer-name
+
 from typing import Iterable
 
 import pytest
@@ -21,6 +25,8 @@ from glowtables.sparql import SparqlBackend
 
 
 class RdflibSparqlBackend(SparqlBackend):
+    """Mock SPARQL backend that queries a local rdflib graph."""
+
     def __init__(self, graph: rdflib.Graph):
         self._graph = graph
 
@@ -30,10 +36,12 @@ class RdflibSparqlBackend(SparqlBackend):
 
 
 @pytest.fixture()
-def rdflib_graph():
+def rdflib_graph() -> rdflib.Graph:
+    """Returns an empty rdflib graph."""
     return rdflib.Graph()
 
 
 @pytest.fixture()
-def rdflib_sparql(rdflib_graph: rdflib.Graph):
+def rdflib_sparql(rdflib_graph: rdflib.Graph) -> RdflibSparqlBackend:
+    """Returns a SPARQL backend instance for ``rdflib_graph``."""
     return RdflibSparqlBackend(rdflib_graph)
diff --git a/glowtables/tests/table_test.py b/glowtables/tests/table_test.py
index faa8105..3a3e1a3 100644
--- a/glowtables/tests/table_test.py
+++ b/glowtables/tests/table_test.py
@@ -19,8 +19,10 @@ import rdflib
 
 from glowtables.table import Language, LiteralField, Table
 
+from .conftest import RdflibSparqlBackend
 
-def test_single_literal(rdflib_sparql) -> None:
+
+def test_single_literal(rdflib_sparql: RdflibSparqlBackend) -> None:
     name_field = LiteralField(
         "display_name",
         {Language("en"): "Name"},
@@ -44,7 +46,7 @@ def test_single_literal(rdflib_sparql) -> None:
     rdflib_sparql.query(table.sparql())
 
 
-def test_two_literals(rdflib_sparql) -> None:
+def test_two_literals(rdflib_sparql: RdflibSparqlBackend) -> None:
     name_field = LiteralField(
         "display_name",
         {Language("en"): "Name"},
@@ -74,7 +76,7 @@ def test_two_literals(rdflib_sparql) -> None:
     rdflib_sparql.query(table.sparql())
 
 
-def test_default_value(rdflib_sparql) -> None:
+def test_default_value(rdflib_sparql: RdflibSparqlBackend) -> None:
     name_field = LiteralField(
         "display_name",
         {Language("en"): "Name"},
diff --git a/pyproject.toml b/pyproject.toml
index afd4a04..e96213c 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -54,6 +54,9 @@ disable = [
     # flake8 does it already:
     "line-too-long",
 ]
+ignore-paths = [
+    "glowtables/tests/.*_test.py"
+]
 
 [tool.pytest.ini_options]
 python_files = "*_test.py"