From 3083aeeb24bd2d5cd0feec6eeedc13b93e5aea10 Mon Sep 17 00:00:00 2001 From: Shivaram Lingamneni Date: Sun, 10 Apr 2022 02:39:30 -0400 Subject: [PATCH] fix processing of multiline CAP LS 302 output (#153) connectClient implicitly assumed that the CAP LS 302 output would be a single registration message. This caused incorrect skipping of some tests with `skip_if_cap_nak=True`, for example RegisterEmailVerifiedTestCase.testAfterConnect on Ergo. Technically there is no need for connectClient to send CAP LS before CAP REQ; however, this provides additional test coverage for the syntactic correctness of the CAP LS output in multiple server configurations, so we might as well keep it. --- irctest/cases.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/irctest/cases.py b/irctest/cases.py index 4dbd43a..0a64c1a 100644 --- a/irctest/cases.py +++ b/irctest/cases.py @@ -672,7 +672,7 @@ class BaseServerTestCase( client = self.addClient(name, show_io=show_io) if capabilities: self.sendLine(client, "CAP LS 302") - m = self.getRegistrationMessage(client) + self.getCapLs(client) self.requestCapabilities(client, capabilities, skip_if_cap_nak) if password is not None: if "sasl" not in (capabilities or ()):