val/irctest
1
0
Fork 0
mirror of https://github.com/progval/irctest.git synced 2025-04-06 07:19:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use assertMessageMatch whenever possible, and generalize listMatch to accept regexps

Browse Source 
it's stricter this way + hopefully more readable and better error msgs
This commit is contained in:
Valentin Lorentz
2021-02-28 20:44:50 +01:00
committed by Valentin Lorentz
parent e012c5248b
commit 3f231403ba
15 changed files with 146 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -26,7 +26,7 @@ Alternatively, run `pre-commit run -a`
[Follow PEP 8](https://www.python.org/dev/peps/pep-0008/#naming-conventions),
with these exceptions:
* assertion methods (eg. `assertMessageEqual` are mixedCase to be consistent
* assertion methods (eg. `assertMessageMatch` are mixedCase to be consistent
with the unittest module)
* other methods defined in `cases.py` are also mixedCase for consistency with
the former, for now
@ -67,7 +67,7 @@ This does not relax the requirement on documentating tests.
**Use unittest-style assertions** (`self.assertEqual(x, y)` instead of
pytest-style (`assert x == y`). This allows consistency with the assertion
methods we define, such as `assertMessageEqual`.
methods we define, such as `assertMessageMatch`.
Always **add an error message in assertions**.
`irctest` should show readable errors to people unfamiliar with the