val/irctest
1
0
Fork 0
mirror of https://github.com/progval/irctest.git synced 2025-04-06 23:39:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

whowas: Update quotes and links to Modern spec

Browse Source 
In particular, this takes https://github.com/ircdocs/modern-irc/pull/196
into account.
This commit is contained in:
Valentin Lorentz
2022-10-22 15:21:19 +02:00
committed by Val Lorentz
parent 690aaf24a1
commit 65d7e0e506
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
irctest/server_tests/whowas.py
View File

@ -98,7 +98,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
"Servers MUST reply with either ERR_WASNOSUCHNICK or [...], "Servers MUST reply with either ERR_WASNOSUCHNICK or [...],
both followed with RPL_ENDOFWHOWAS" both followed with RPL_ENDOFWHOWAS"
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
""" """
self.connectClient("nick1") self.connectClient("nick1")
@ -210,7 +210,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
"The history is searched backward, returning the most recent entry first." "The history is searched backward, returning the most recent entry first."
-- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3 -- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3
-- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 -- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
""" """
self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2") self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2")
@ -224,7 +224,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
"If there are multiple entries, up to <count> replies will be returned" "If there are multiple entries, up to <count> replies will be returned"
-- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3 -- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3
-- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 -- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
""" """
self._testWhowasMultiple(second_result=False, whowas_command="WHOWAS nick2 1") self._testWhowasMultiple(second_result=False, whowas_command="WHOWAS nick2 1")
@ -238,7 +238,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
"If there are multiple entries, up to <count> replies will be returned" "If there are multiple entries, up to <count> replies will be returned"
-- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3 -- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3
-- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 -- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
""" """
self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2 2") self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2 2")
@ -253,7 +253,10 @@ class WhowasTestCase(cases.BaseServerTestCase):
is done." is done."
-- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3 -- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3
-- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 -- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
-- https://github.com/ircdocs/modern-irc/pull/170
"If given, <count> SHOULD be a positive number. Otherwise, a full search
"is done.
-- https://modern.ircdocs.horse/#whowas-message
""" """
self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2 -1") self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2 -1")
@ -271,7 +274,10 @@ class WhowasTestCase(cases.BaseServerTestCase):
is done." is done."
-- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3 -- https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3
-- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 -- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
-- https://github.com/ircdocs/modern-irc/pull/170
"If given, <count> SHOULD be a positive number. Otherwise, a full search
"is done.
-- https://modern.ircdocs.horse/#whowas-message
""" """
self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2 0") self._testWhowasMultiple(second_result=True, whowas_command="WHOWAS nick2 0")
@ -280,7 +286,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
""" """
"Wildcards are allowed in the <target> parameter." "Wildcards are allowed in the <target> parameter."
-- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 -- https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
""" """
if self.controller.software_name == "Bahamut": if self.controller.software_name == "Bahamut":
raise runner.OptionalExtensionNotSupported("WHOWAS mask") raise runner.OptionalExtensionNotSupported("WHOWAS mask")
@ -324,7 +330,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
""" """
"If the `<nick>` argument is missing, they SHOULD send a single reply, using "If the `<nick>` argument is missing, they SHOULD send a single reply, using
either ERR_NONICKNAMEGIVEN or ERR_NEEDMOREPARAMS" either ERR_NONICKNAMEGIVEN or ERR_NEEDMOREPARAMS"
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
""" """
# But no one seems to follow this. Most implementations use ERR_NEEDMOREPARAMS # But no one seems to follow this. Most implementations use ERR_NEEDMOREPARAMS
# instead of ERR_NONICKNAMEGIVEN; and I couldn't find any that returns # instead of ERR_NONICKNAMEGIVEN; and I couldn't find any that returns
@ -358,7 +364,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
""" """
https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3 https://datatracker.ietf.org/doc/html/rfc1459#section-4.5.3
https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3 https://datatracker.ietf.org/doc/html/rfc2812#section-3.6.3
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
and: and:
@ -371,7 +377,7 @@ class WhowasTestCase(cases.BaseServerTestCase):
"Servers MUST reply with either ERR_WASNOSUCHNICK or [...], "Servers MUST reply with either ERR_WASNOSUCHNICK or [...],
both followed with RPL_ENDOFWHOWAS" both followed with RPL_ENDOFWHOWAS"
-- https://github.com/ircdocs/modern-irc/pull/170 -- https://modern.ircdocs.horse/#whowas-message
""" """
self.connectClient("nick1") self.connectClient("nick1")