val/irctest
1
0
Fork 0
mirror of https://github.com/progval/irctest.git synced 2025-04-05 23:09:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Exclude ircu2 and fill in the spec

Browse Source
This commit is contained in:
Valentin Lorentz
2021-08-13 21:39:13 +02:00
committed by Val Lorentz
parent e03bb4734d
commit 8bc9c5b057
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -63,6 +63,7 @@ INSPIRCD_SELECTORS := \
# statusmsg tests fail because STATUSMSG is present in ISUPPORT, but it not actually supported as PRIVMSG target # statusmsg tests fail because STATUSMSG is present in ISUPPORT, but it not actually supported as PRIVMSG target
# testKeyValidation[empty] fails because ircu2 returns ERR_NEEDMOREPARAMS on empty keys: https://github.com/UndernetIRC/ircu2/issues/13 # testKeyValidation[empty] fails because ircu2 returns ERR_NEEDMOREPARAMS on empty keys: https://github.com/UndernetIRC/ircu2/issues/13
# testKickDefaultComment fails because it uses the nick of the kickee rather than the kicker. # testKickDefaultComment fails because it uses the nick of the kickee rather than the kicker.
# testEmptyRealname fails because it uses a default value instead of ERR_NEEDMOREPARAMS.
IRCU2_SELECTORS := \ IRCU2_SELECTORS := \
not Ergo \ not Ergo \
and not deprecated \ and not deprecated \
@ -73,6 +74,7 @@ IRCU2_SELECTORS := \
and not statusmsg \ and not statusmsg \
and not (testKeyValidation and empty) \ and not (testKeyValidation and empty) \
and not testKickDefaultComment \ and not testKickDefaultComment \
and not testEmptyRealname \
$(EXTRA_SELECTORS) $(EXTRA_SELECTORS)
# same justification as ircu2 # same justification as ircu2

6
irctest/server_tests/connection_registration.py
View File

@ -169,7 +169,11 @@ class ConnectionRegistrationTestCase(cases.BaseServerTestCase):
-- https://defs.ircdocs.horse/defs/numerics.html#err-needmoreparams-461 -- https://defs.ircdocs.horse/defs/numerics.html#err-needmoreparams-461
-- https://modern.ircdocs.horse/#errneedmoreparams-461 -- https://modern.ircdocs.horse/#errneedmoreparams-461
Use of this numeric: TBD https://github.com/ircdocs/modern-irc/issues/85 Use of this numeric:
"The minimum length of `<username>` is 1, ie. it MUST not be empty.
If it is empty, the server SHOULD reject the command with ERR_NEEDMOREPARAMS
(even an empty parameter is provided)"
https://github.com/ircdocs/modern-irc/issues/85
""" """
self.addClient() self.addClient()
self.sendLine(1, "NICK foo") self.sendLine(1, "NICK foo")