val/irctest
1
0
Fork 0
mirror of https://github.com/progval/irctest.git synced 2025-04-05 06:49:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_sasl: Unify successful auth checking a bit more

Browse Source
This commit is contained in:
Daniel Oaks
2016-11-29 22:37:08 +10:00
parent 9ede9045ad
commit da25b59380
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
irctest/server_tests/test_sasl.py
View File

@ -129,6 +129,10 @@ class SaslTestCase(cases.BaseServerTestCase, cases.OptionalityHelper):
self.sendLine(1, 'AUTHENTICATE {}'.format(authstring[0:400])) self.sendLine(1, 'AUTHENTICATE {}'.format(authstring[0:400]))
self.sendLine(1, 'AUTHENTICATE {}'.format(authstring[400:])) self.sendLine(1, 'AUTHENTICATE {}'.format(authstring[400:]))
self.confirmSuccessfulAuth()
def confirmSuccessfulAuth(self):
# TODO: check username/etc in this as well, so we can apply it to other tests
# TODO: may be in the other order # TODO: may be in the other order
m = self.getRegistrationMessage(1) m = self.getRegistrationMessage(1)
self.assertMessageEqual(m, command='900', self.assertMessageEqual(m, command='900',
@ -136,7 +140,7 @@ class SaslTestCase(cases.BaseServerTestCase, cases.OptionalityHelper):
'login, but got: {msg}') 'login, but got: {msg}')
m = self.getRegistrationMessage(1) m = self.getRegistrationMessage(1)
self.assertMessageEqual(m, command='903', self.assertMessageEqual(m, command='903',
fail_msg='Expected 900 (RPL_LOGGEDIN) after successful ' fail_msg='Expected 903 (RPL_SASLSUCCESS) after successful '
'login, but got: {msg}') 'login, but got: {msg}')
# TODO: add a test for when the length of the authstring is greater than 800. # TODO: add a test for when the length of the authstring is greater than 800.
@ -171,15 +175,7 @@ class SaslTestCase(cases.BaseServerTestCase, cases.OptionalityHelper):
self.sendLine(1, 'AUTHENTICATE {}'.format(authstring)) self.sendLine(1, 'AUTHENTICATE {}'.format(authstring))
self.sendLine(1, 'AUTHENTICATE +') self.sendLine(1, 'AUTHENTICATE +')
# TODO: may be in the other order self.confirmSuccessfulAuth()
m = self.getRegistrationMessage(1)
self.assertMessageEqual(m, command='900',
fail_msg='Expected 900 (RPL_LOGGEDIN) after successful '
'login, but got: {msg}')
m = self.getRegistrationMessage(1)
self.assertMessageEqual(m, command='903',
fail_msg='Expected 900 (RPL_LOGGEDIN) after successful '
'login, but got: {msg}')
# TODO: add a test for when the length of the authstring is 800. # TODO: add a test for when the length of the authstring is 800.
# I don't know how to do it, because it would make the registration # I don't know how to do it, because it would make the registration