From dbdadec6770a47e8a70578b8b7d8b61879bd9cb7 Mon Sep 17 00:00:00 2001 From: Shivaram Lingamneni Date: Fri, 26 Aug 2022 10:01:41 -0700 Subject: [PATCH] test that WHO ignores +i for bare nicknames (#171) --- irctest/server_tests/who.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/irctest/server_tests/who.py b/irctest/server_tests/who.py index 10430d8..4956bd5 100644 --- a/irctest/server_tests/who.py +++ b/irctest/server_tests/who.py @@ -503,3 +503,34 @@ class WhoServicesTestCase(BaseWhoTestCase, cases.BaseServerTestCase): command=RPL_ENDOFWHO, params=["otherNick", InsensitiveStr("coolNick"), ANYSTR], ) + + +class WhoInvisibleTestCase(cases.BaseServerTestCase): + @cases.mark_specifications("Modern") + def testWhoInvisible(self): + if self.controller.software_name == "Bahamut": + raise runner.OptionalExtensionNotSupported("WHO mask") + + self.connectClient("evan", name="evan") + self.sendLine("evan", "MODE evan +i") + self.getMessages("evan") + + self.connectClient("shivaram", name="shivaram") + self.getMessages("shivaram") + self.sendLine("shivaram", "WHO eva*") + reply_cmds = {msg.command for msg in self.getMessages("shivaram")} + self.assertEqual(reply_cmds, {RPL_ENDOFWHO}) + + # invisibility should not be respected for plain nicknames, only for masks: + self.sendLine("shivaram", "WHO evan") + replies = self.getMessages("shivaram") + reply_cmds = {msg.command for msg in replies} + self.assertEqual(reply_cmds, {RPL_WHOREPLY, RPL_ENDOFWHO}) + + # invisibility should not be respected if the users share a channel + self.joinChannel("evan", "#test") + self.joinChannel("shivaram", "#test") + self.sendLine("shivaram", "WHO eva*") + replies = self.getMessages("shivaram") + reply_cmds = {msg.command for msg in replies} + self.assertEqual(reply_cmds, {RPL_WHOREPLY, RPL_ENDOFWHO})