val/irctest
1
0
Fork 0
mirror of https://github.com/progval/irctest.git synced 2025-04-08 00:09:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

reenable some account-registration tests for Ergo

Browse Source 
These were incorrectly being skipped. If `CAP LS 302` precedes
`requestCapabilities`, `requestCapabilities` sees the LS response
instead of the ACK it expects. Then it assumes that the request was
NAK'ed and skips the test.
This commit is contained in:
Shivaram Lingamneni
2021-07-30 12:10:49 -04:00
committed by Val Lorentz
parent aee6750e7d
commit f63de0548a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
irctest/server_tests/test_register_verify.py
View File

@ -15,8 +15,8 @@ class TestRegisterBeforeConnect(cases.BaseServerTestCase):
def testBeforeConnect(self): def testBeforeConnect(self):
self.addClient("bar") self.addClient("bar")
self.sendLine("bar", "CAP LS 302")
self.requestCapabilities("bar", [REGISTER_CAP_NAME], skip_if_cap_nak=True) self.requestCapabilities("bar", [REGISTER_CAP_NAME], skip_if_cap_nak=True)
self.sendLine("bar", "CAP LS 302")
caps = self.getCapLs("bar") caps = self.getCapLs("bar")
self.assertIn(REGISTER_CAP_NAME, caps) self.assertIn(REGISTER_CAP_NAME, caps)
self.assertIn("before-connect", caps[REGISTER_CAP_NAME]) self.assertIn("before-connect", caps[REGISTER_CAP_NAME])
@ -38,8 +38,8 @@ class TestRegisterBeforeConnectDisallowed(cases.BaseServerTestCase):
def testBeforeConnect(self): def testBeforeConnect(self):
self.addClient("bar") self.addClient("bar")
self.sendLine("bar", "CAP LS 302")
self.requestCapabilities("bar", [REGISTER_CAP_NAME], skip_if_cap_nak=True) self.requestCapabilities("bar", [REGISTER_CAP_NAME], skip_if_cap_nak=True)
self.sendLine("bar", "CAP LS 302")
caps = self.getCapLs("bar") caps = self.getCapLs("bar")
self.assertIn(REGISTER_CAP_NAME, caps) self.assertIn(REGISTER_CAP_NAME, caps)
self.assertEqual(caps[REGISTER_CAP_NAME], None) self.assertEqual(caps[REGISTER_CAP_NAME], None)
@ -72,10 +72,10 @@ class TestRegisterEmailVerified(cases.BaseServerTestCase):
def testBeforeConnect(self): def testBeforeConnect(self):
self.addClient("bar") self.addClient("bar")
self.sendLine("bar", "CAP LS 302")
self.requestCapabilities( self.requestCapabilities(
"bar", capabilities=[REGISTER_CAP_NAME], skip_if_cap_nak=True "bar", capabilities=[REGISTER_CAP_NAME], skip_if_cap_nak=True
) )
self.sendLine("bar", "CAP LS 302")
caps = self.getCapLs("bar") caps = self.getCapLs("bar")
self.assertIn(REGISTER_CAP_NAME, caps) self.assertIn(REGISTER_CAP_NAME, caps)
self.assertEqual( self.assertEqual(