From fc07fa7d9612fbd5fa14c1433b23470cb6c46570 Mon Sep 17 00:00:00 2001 From: Valentin Lorentz Date: Sat, 3 Jul 2021 11:48:25 +0200 Subject: [PATCH] Don't check for NickServ availability multiple times per test It's a waste of time. --- irctest/basecontrollers.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/irctest/basecontrollers.py b/irctest/basecontrollers.py index 827638e..6bf0494 100644 --- a/irctest/basecontrollers.py +++ b/irctest/basecontrollers.py @@ -244,8 +244,12 @@ class BaseServicesController(_BaseController): super().__init__(test_config) self.test_config = test_config self.server_controller = server_controller + self.services_up = False def wait_for_services(self) -> None: + if self.services_up: + # Don't check again if they are already available + return self.server_controller.wait_for_port() c = ClientMock(name="chkNS", show_io=True) @@ -285,6 +289,7 @@ class BaseServicesController(_BaseController): c.sendLine("QUIT") c.getMessages() c.disconnect() + self.services_up = True def getNickServResponse(self, client: Any) -> List[Message]: """Wrapper aroung getMessages() that waits longer, because NickServ