From 5dfe161bac27a1b4690acb097aaefe86a438ebb0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Eli=C3=A1n=20Hanisch?= <lambdae2@gmail.com>
Date: Tue, 30 Mar 2010 14:02:53 -0300
Subject: [PATCH] tweak reviewTime initialisation and comments++

---
 Bantracker/plugin.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Bantracker/plugin.py b/Bantracker/plugin.py
index 32c5b8f..beed1ae 100644
--- a/Bantracker/plugin.py
+++ b/Bantracker/plugin.py
@@ -188,7 +188,7 @@ class Bantracker(callbacks.Plugin):
             self.db = None
         self.get_bans(irc)
         self.get_nicks(irc)
-        # schedule
+        # add scheduled event for check bans that need review
         schedule.addPeriodicEvent(lambda : self.reviewBans(irc), 20,
                 name=self.name)
 
@@ -387,7 +387,8 @@ class Bantracker(callbacks.Plugin):
             lastreview = self.registryValue('reviewTime')
             reviewAfterTime = self.registryValue('reviewAfterTime') * 60 # time in mins
             if not lastreview:
-                lastreview = now
+                # initialize last time reviewed timestamp
+                lastreview = now - reviewAfterTime
             for channel, bans in self.bans.iteritems():
                 for ban in bans:
                     banTime = now - ban.when
@@ -395,6 +396,7 @@ class Bantracker(callbacks.Plugin):
                     self.log.debug('  channel %s ban %s (%s/%s/%s)', channel, ban.mask, reviewTime,
                             reviewAfterTime, banTime)
                     if reviewTime <= reviewAfterTime < banTime:
+                        # ban is old enough, and inside the "review window"
                         op = ban.who
                         # ban.who can be a nick or IRC hostmask
                         if ircutils.isUserHostmask(op):