Deselect testKeyValidation[empty] for ircu2

This commit is contained in:
Valentin Lorentz 2021-08-11 22:29:29 +02:00 committed by Val Lorentz
parent 3cca1ce29e
commit 57a08a0a57
2 changed files with 7 additions and 1 deletions

View File

@ -56,6 +56,7 @@ INSPIRCD_SELECTORS := \
# testQuit and testQuitErrors fail because ircu2 does not send ERROR or QUIT
# lusers tests fail because they depend on Modern behavior, not just RFC2812 (TODO: update lusers tests to accept RFC2812-compliant implementations)
# statusmsg tests fail because STATUSMSG is present in ISUPPORT, but it not actually supported as PRIVMSG target
# testKeyValidation[empty] fails because ircu2 returns ERR_NEEDMOREPARAMS on empty keys: https://github.com/UndernetIRC/ircu2/issues/13
IRCU2_SELECTORS := \
not Ergo \
and not deprecated \
@ -64,6 +65,7 @@ IRCU2_SELECTORS := \
and not testQuit \
and not lusers \
and not statusmsg \
and not (testKeyValidation and empty) \
$(EXTRA_SELECTORS)
# same justification as ircu2

View File

@ -46,7 +46,11 @@ class KeyTestCase(cases.BaseServerTestCase):
reply = self.getMessages(2)
self.assertMessageMatch(reply[0], command="JOIN", params=["#chan"])
@pytest.mark.parametrize("key", ["passphrase with spaces", "long" * 100, ""])
@pytest.mark.parametrize(
"key",
["passphrase with spaces", "long" * 100, ""],
ids=["spaces", "long", "empty"],
)
@cases.mark_specifications("RFC2812", "Modern")
def testKeyValidation(self, key):
"""