val/irctest
1
0
Fork 0
mirror of https://github.com/progval/irctest.git synced 2025-04-08 00:09:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deselect testKeyValidation[empty] for ircu2

Browse Source
This commit is contained in:
Valentin Lorentz
2021-08-11 22:29:29 +02:00
committed by Val Lorentz
parent 3cca1ce29e
commit 57a08a0a57
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -56,6 +56,7 @@ INSPIRCD_SELECTORS := \
# testQuit and testQuitErrors fail because ircu2 does not send ERROR or QUIT # testQuit and testQuitErrors fail because ircu2 does not send ERROR or QUIT
# lusers tests fail because they depend on Modern behavior, not just RFC2812 (TODO: update lusers tests to accept RFC2812-compliant implementations) # lusers tests fail because they depend on Modern behavior, not just RFC2812 (TODO: update lusers tests to accept RFC2812-compliant implementations)
# statusmsg tests fail because STATUSMSG is present in ISUPPORT, but it not actually supported as PRIVMSG target # statusmsg tests fail because STATUSMSG is present in ISUPPORT, but it not actually supported as PRIVMSG target
# testKeyValidation[empty] fails because ircu2 returns ERR_NEEDMOREPARAMS on empty keys: https://github.com/UndernetIRC/ircu2/issues/13
IRCU2_SELECTORS := \ IRCU2_SELECTORS := \
not Ergo \ not Ergo \
and not deprecated \ and not deprecated \
@ -64,6 +65,7 @@ IRCU2_SELECTORS := \
and not testQuit \ and not testQuit \
and not lusers \ and not lusers \
and not statusmsg \ and not statusmsg \
and not (testKeyValidation and empty) \
$(EXTRA_SELECTORS) $(EXTRA_SELECTORS)
# same justification as ircu2 # same justification as ircu2

6
irctest/server_tests/mode.py
View File

@ -46,7 +46,11 @@ class KeyTestCase(cases.BaseServerTestCase):
reply = self.getMessages(2) reply = self.getMessages(2)
self.assertMessageMatch(reply[0], command="JOIN", params=["#chan"]) self.assertMessageMatch(reply[0], command="JOIN", params=["#chan"])
@pytest.mark.parametrize("key", ["passphrase with spaces", "long" * 100, ""]) @pytest.mark.parametrize(
"key",
["passphrase with spaces", "long" * 100, ""],
ids=["spaces", "long", "empty"],
)
@cases.mark_specifications("RFC2812", "Modern") @cases.mark_specifications("RFC2812", "Modern")
def testKeyValidation(self, key): def testKeyValidation(self, key):
""" """