basic test case for KILL (#302)

irctest/controllers/charybdis.py

@@ -60,7 +60,7 @@ privset "omnioper" {{
     privs = oper:general, oper:privs, oper:testline, oper:kill, oper:operwall, oper:message,
             oper:routing, oper:kline, oper:unkline, oper:xline,
             oper:resv, oper:cmodes, oper:mass_notice, oper:wallops,
-            oper:remoteban,
+            oper:remoteban, oper:local_kill,
             usermode:servnotice, auspex:oper, auspex:hostname, auspex:umodes, auspex:cmodes,
             oper:admin, oper:die, oper:rehash, oper:spy, oper:grant;
 }};

irctest/controllers/inspircd.py

@@ -19,7 +19,7 @@ TEMPLATE_CONFIG = """
 
 <class
     name="ServerOperators"
-    commands="WALLOPS GLOBOPS"
+    commands="WALLOPS GLOBOPS KILL"
     privs="channels/auspex users/auspex channels/auspex servers/auspex"
     >
 <type

irctest/controllers/irc2.py

@@ -24,7 +24,7 @@ Y:10:90::100:512000:100.100:100.100:
 I::{password_field}:::10::
 
 # O:<TARGET Host NAME>:<Password>:<Nickname>:<Port>:<Class>:<Flags>:
-O:*:operpassword:operuser::::
+O:*:operpassword:operuser:::K:
 """
 
 

irctest/server_tests/kill.py

@@ -0,0 +1,67 @@
+"""
+The KILL command  (`Modern <https://modern.ircdocs.horse/#kill-message>`__)
+"""
+
+
+from irctest import cases
+from irctest.numerics import ERR_NOPRIVILEGES, RPL_YOUREOPER
+
+
+class KillTestCase(cases.BaseServerTestCase):
+    @cases.mark_specifications("Modern")
+    @cases.xfailIfSoftware(["Sable"], "https://github.com/Libera-Chat/sable/issues/154")
+    def testKill(self):
+        self.connectClient("ircop", name="ircop")
+        self.connectClient("alice", name="alice")
+        self.connectClient("bob", name="bob")
+
+        self.sendLine("ircop", "OPER operuser operpassword")
+        self.assertIn(
+            RPL_YOUREOPER,
+            [m.command for m in self.getMessages("ircop")],
+            fail_msg="OPER failed",
+        )
+
+        self.sendLine("alice", "KILL bob :some arbitrary reason")
+        self.assertIn(
+            ERR_NOPRIVILEGES,
+            [m.command for m in self.getMessages("alice")],
+            fail_msg="unprivileged KILL not rejected",
+        )
+        # bob is not killed
+        self.getMessages("bob")
+
+        self.sendLine("alice", "KILL alice :some arbitrary reason")
+        self.assertIn(
+            ERR_NOPRIVILEGES,
+            [m.command for m in self.getMessages("alice")],
+            fail_msg="unprivileged KILL not rejected",
+        )
+        # alice is not killed
+        self.getMessages("alice")
+
+        # privileged KILL should succeed
+        self.sendLine("ircop", "KILL alice :some arbitrary reason")
+        self.getMessages("ircop")
+        self.assertDisconnected("alice")
+
+        self.sendLine("ircop", "KILL bob :some arbitrary reason")
+        self.getMessages("ircop")
+        self.assertDisconnected("bob")
+
+    @cases.mark_specifications("Ergo")
+    def testKillOneArgument(self):
+        self.connectClient("ircop", name="ircop")
+        self.connectClient("alice", name="alice")
+
+        self.sendLine("ircop", "OPER operuser operpassword")
+        self.assertIn(
+            RPL_YOUREOPER,
+            [m.command for m in self.getMessages("ircop")],
+            fail_msg="OPER failed",
+        )
+
+        # 1-argument kill command, accepted by Ergo and some implementations
+        self.sendLine("ircop", "KILL alice")
+        self.getMessages("ircop")
+        self.assertDisconnected("alice")