val/irctest
1
0
Fork 0
mirror of https://github.com/progval/irctest.git synced 2025-04-06 07:19:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

add regression test for #1252

Browse Source
This commit is contained in:
Shivaram Lingamneni
2020-08-29 23:28:41 -04:00
parent 0bdbe2ce24
commit ed2b6148e5
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
irctest/server_tests/test_regressions.py
View File

@ -4,7 +4,7 @@ Regression tests for bugs in oragono.
from irctest import cases
from irctest.numerics import ERR_ERRONEUSNICKNAME, RPL_WELCOME
from irctest.numerics import ERR_ERRONEUSNICKNAME, ERR_NICKNAMEINUSE, RPL_WELCOME
class RegressionsTestCase(cases.BaseServerTestCase):
@ -18,7 +18,7 @@ class RegressionsTestCase(cases.BaseServerTestCase):
self.sendLine(2, 'NICK alice')
ms = self.getMessages(2)
self.assertEqual(len(ms), 1)
self.assertMessageEqual(ms[0], command='433') # ERR_NICKNAMEINUSE
self.assertMessageEqual(ms[0], command=ERR_NICKNAMEINUSE)
# bob MUST still own the bob nick, and be able to receive PRIVMSG as bob
self.sendLine(1, 'PRIVMSG bob hi')
@ -82,7 +82,6 @@ class RegressionsTestCase(cases.BaseServerTestCase):
self.assertMessageEqual(ms[0], command='PRIVMSG', params=['bob', 'hey again'])
self.assertEqual(ms[0].tags.get('+draft/reply'), 'tbxqauh9nykrtpa3n6icd9whan')
@cases.SpecificationSelector.requiredBySpecification('RFC1459')
def testStarNick(self):
self.addClient(1)
@ -96,3 +95,20 @@ class RegressionsTestCase(cases.BaseServerTestCase):
replies = set(msg.command for msg in self.getMessages(1))
self.assertNotIn(ERR_ERRONEUSNICKNAME, replies)
self.assertIn(RPL_WELCOME, replies)
@cases.SpecificationSelector.requiredBySpecification('RFC1459')
def testNickRelease(self):
# regression test for oragono #1252
self.connectClient('alice')
self.getMessages(1)
self.sendLine(1, 'NICK malice')
nick_msgs = [msg for msg in self.getMessages(1) if msg.command == 'NICK']
self.assertEqual(len(nick_msgs), 1)
self.assertMessageEqual(nick_msgs[0], command='NICK', params=['malice'])
self.addClient(2)
self.sendLine(2, 'NICK alice')
self.sendLine(2, 'USER u s e r')
replies = set(msg.command for msg in self.getMessages(2))
self.assertNotIn(ERR_NICKNAMEINUSE, replies)
self.assertIn(RPL_WELCOME, replies)