Bump Bahamut (#291)

The patch does not apply to the latest master, so we need to update it

.github/workflows/test-devel.yml

@@ -558,7 +558,7 @@ jobs:
         repository: ergochat/ergo
     - uses: actions/setup-go@v3
       with:
-        go-version: ^1.22.0
+        go-version: ^1.23.0
     - run: go version
     - name: Build Ergo
       run: |

.github/workflows/test-stable.yml

@@ -65,7 +65,7 @@ jobs:
       uses: actions/checkout@v4
       with:
         path: Bahamut
-        ref: v2.2.1
+        ref: v2.2.4
         repository: DALnet/Bahamut
     - name: Build Bahamut
       run: |
@@ -636,7 +636,7 @@ jobs:
         repository: ergochat/ergo
     - uses: actions/setup-go@v3
       with:
-        go-version: ^1.22.0
+        go-version: ^1.23.0
     - run: go version
     - name: Build Ergo
       run: |

irctest/controllers/sable.py

@@ -107,6 +107,8 @@ NETWORK_CONFIG = """
 
 NETWORK_CONFIG_CONFIG = """
 {
+    "object_expiry": 300,
+
     "opers": [
         {
             "name": "operuser",

irctest/server_tests/messages.py

@@ -2,8 +2,6 @@
 The PRIVMSG and NOTICE commands.
 """
 
-import pytest
-
 from irctest import cases
 from irctest.numerics import ERR_INPUTTOOLONG
 from irctest.patma import ANYSTR
@@ -125,31 +123,26 @@ class NoticeTestCase(cases.BaseServerTestCase):
 
 
 class TagsTestCase(cases.BaseServerTestCase):
-    @pytest.mark.parametrize("tag_length", [4096, 10000])
     @cases.mark_capabilities("message-tags")
     @cases.xfailIf(
-        lambda self, tag_length: bool(
+        lambda self: bool(
             self.controller.software_name == "UnrealIRCd"
             and self.controller.software_version == 5
         ),
         "UnrealIRCd <6.0.7 dropped messages with excessively large tags: "
         "https://bugs.unrealircd.org/view.php?id=5947",
     )
-    def testLineTooLong(self, tag_length):
+    def testLineTooLong(self):
         self.connectClient("bar", capabilities=["message-tags"], skip_if_cap_nak=True)
         self.connectClient(
             "recver", capabilities=["message-tags"], skip_if_cap_nak=True
         )
         self.joinChannel(1, "#xyz")
-
-        monsterMessage = (
-            "@+clientOnlyTagExample=" + "a" * tag_length + " PRIVMSG #xyz hi!"
-        )
+        monsterMessage = "@+clientOnlyTagExample=" + "a" * 4096 + " PRIVMSG #xyz hi!"
         self.sendLine(1, monsterMessage)
         replies = self.getMessages(1)
+        self.assertIn(ERR_INPUTTOOLONG, set(reply.command for reply in replies))
         self.assertEqual(self.getMessages(2), [], "overflowing message was relayed")
-        if len(replies) > 0:
-            self.assertIn(ERR_INPUTTOOLONG, set(reply.command for reply in replies))
 
 
 class LengthLimitTestCase(cases.BaseServerTestCase):

patches/bahamut_localhost.patch

@@ -8,13 +8,13 @@ index 317b00e..adfcfcf 100644
  	    dots = 1;
  	}
  
--	if (!dots) 
+-	if (!dots)
 -        {
 -            sendto_realops("Invalid hostname for %s, dumping user %s",
 -                           sptr->hostip, sptr->name);
 -            return exit_client(cptr, sptr, &me, "Invalid hostname");
 -        }
--        
-         if (bad_dns) 
+-
+         if (bad_dns)
          {
              sendto_one(sptr, ":%s NOTICE %s :*** Notice -- You have a bad "

workflows.yml

@@ -97,7 +97,7 @@ software:
         name: Bahamut
         repository: DALnet/Bahamut
         refs:
-            stable: "v2.2.1"
+            stable: "v2.2.4"
             release: null
             devel: "master"
             devel_release: null
@@ -136,7 +136,7 @@ software:
         pre_deps:
             - uses: actions/setup-go@v3
               with:
-                  go-version: '^1.22.0'
+                  go-version: '^1.23.0'
             - run: go version
         separate_build_job: false
         build_script: |