val/jable
1
0
Fork 0
Code Issues Pull Requests Activity

Model topic as causal register instead of linearizable

Browse Source 
Sable doesn't do quorum reads or write, so it's not linearizable
This commit is contained in:
Val Lorentz
2023-09-17 13:52:06 +02:00
parent d7651e512b
commit 76086f6f20
2 changed files with 40 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/jable/cli.clj
View File

@ -16,31 +16,17 @@
[tests :as tests]
[checker :as checker]
[generator :as gen]
[independent :as independent]
[nemesis :as nemesis]]
[jepsen.tests.causal :as causal]
[jepsen.os.debian :as debian]
[knossos.model :as model]
[jable.client :as client]
[jable.db :as db])
(:import (knossos.model Model)))
(defn r [_ _] {:type :invoke, :f :read-topic, :value nil})
(defn w [_ _] {:type :invoke, :f :write-topic, :value (str (rand-int 5))})
(defrecord Channel [value]
Model
(step [c op]
(case (:f op)
:write-topic (Channel. (:value op))
:read-topic (if (= value (:value op))
c
(model/inconsistent
(str (pr-str value) "≠" (pr-str (:value op)))))))
Object
(toString [r] (pr-str value)))
(defn channel []
(Channel. nil))
(defn r [_ _] {:type :invoke, :f :read, :value nil})
(defn w [_ _] {:type :invoke, :f :write, :value (str (rand-int 5))})
(defn sable-test
"Given an options map from the command line runner (e.g. :nodes, :ssh,
@ -54,9 +40,7 @@
:db (db/sable (:sable-bin opts) (:nodes opts))
:client (client/jable.client.Client. nil nil nil)
:nemesis (nemesis/partition-random-halves)
:checker (checker/linearizable
{:model (channel)
:algorithm :linear})
:checker (independent/checker (causal/check causal/causal-register))
:generator (->> (gen/mix [r w])
(gen/stagger 1)
(gen/nemesis nil)

70
src/jable/client.clj
View File

@ -184,41 +184,41 @@
(invoke! [this test op]
(case (:f op)
:read-topic (do
(send-command this {:tags {"label" "read-topic"}
:cmd "TOPIC"
:params ["#chan"]})
(let [[cmd1 & cmds] (read-response this "read-topic")]
(case (:cmd cmd1)
; RPL_NOTOPIC
"331" (assoc op :type :ok, :value nil)
"BATCH" (let [[topic-cmd topicwhotime-cmd batch-close] cmds]
; RPL_TOPIC
(assert (= (:cmd topic-cmd) "332") (str "expected RPL_TOPIC: " topic-cmd))
; RPL_TOPICWHOTIME
(assert (= (:cmd topicwhotime-cmd) "333") (str "expected RPL_TOPICWHOTIME: " topicwhotime-cmd))
(assert (= (:cmd batch-close) "BATCH") "topic batch close cmd")
(let [[my-nick chan topic] (:params topic-cmd)
[my-nick chan who time] (:params topicwhotime-cmd)]
(let [[nick userhost] (str/split who #"!" 2)
time (Integer/parseInt time)]
(assoc op :type :ok, :value {:topic topic
:who nick
:time time})))))))
:write-topic (do
(send-command this {:tags {"label" "write-topic"}
:cmd "TOPIC"
:params ["#chan" (:value op)]})
(let [[cmd] (read-response this "write-topic")]
(case (:cmd cmd)
; Sable returns ACK when two clients set the same topic value
; at the same time
"ACK" (assoc op :type :fail, :error :noop)
"TOPIC" (let [[chan topic] (:params cmd)
time (/ (.getTime (instant/read-instant-timestamp (get (:tags cmd) "time"))) 1000)]
(assoc op :type :ok, :value {:topic topic
:who (:nick this)
:time time })))))))
:read (do
(send-command this {:tags {"label" "read-topic"}
:cmd "TOPIC"
:params ["#chan"]})
(let [[cmd1 & cmds] (read-response this "read-topic")]
(case (:cmd cmd1)
; RPL_NOTOPIC
"331" (assoc op :type :ok, :value nil)
"BATCH" (let [[topic-cmd topicwhotime-cmd batch-close] cmds]
; RPL_TOPIC
(assert (= (:cmd topic-cmd) "332") (str "expected RPL_TOPIC: " topic-cmd))
; RPL_TOPICWHOTIME
(assert (= (:cmd topicwhotime-cmd) "333") (str "expected RPL_TOPICWHOTIME: " topicwhotime-cmd))
(assert (= (:cmd batch-close) "BATCH") "topic batch close cmd")
(let [[my-nick chan topic] (:params topic-cmd)
[my-nick chan who time] (:params topicwhotime-cmd)]
(let [[nick userhost] (str/split who #"!" 2)
time (Integer/parseInt time)]
(assoc op :type :ok, :value {:topic topic
:who nick
:time time})))))))
:write (do
(send-command this {:tags {"label" "write-topic"}
:cmd "TOPIC"
:params ["#chan" (:value op)]})
(let [[cmd] (read-response this "write-topic")]
(case (:cmd cmd)
; Sable returns ACK when two clients set the same topic value
; at the same time
"ACK" (assoc op :type :fail, :error :noop)
"TOPIC" (let [[chan topic] (:params cmd)
time (/ (.getTime (instant/read-instant-timestamp (get (:tags cmd) "time"))) 1000)]
(assoc op :type :ok, :value {:topic topic
:who (:nick this)
:time time })))))))
(teardown! [this test])